fix: debug_verify_type uses correct entrypoint for multi-def queries#250
Merged
fix: debug_verify_type uses correct entrypoint for multi-def queries#250
debug_verify_type uses correct entrypoint for multi-def queries#250Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
debug_verify_typeto use the actual executed entrypoint's type instead of always usingentrypoints.get(0)--entryDetails
The bug was in
verify.rs:27- it always verified against the first entrypoint alphabetically, not the one passed via--entry. For example, with:Running
--entry Qwould verify againstExpr's type (index 0) instead ofQ's type, causing a type mismatch.Fix: Changed
debug_verify_typesignature to acceptexpected_type: QTypeIddirectly from the caller, who already has the correct entrypoint.